[SPARK-38899][SQL]DS V2 supports push down datetime functions#36663
Closed
chenzhx wants to merge 10 commits into
Closed
[SPARK-38899][SQL]DS V2 supports push down datetime functions#36663chenzhx wants to merge 10 commits into
chenzhx wants to merge 10 commits into
Conversation
beliefer
reviewed
May 25, 2022
cloud-fan
reviewed
May 26, 2022
cloud-fan
reviewed
May 26, 2022
cloud-fan
reviewed
May 26, 2022
cloud-fan
approved these changes
May 26, 2022
huaxingao
reviewed
May 26, 2022
57b2b2f to
8d33d08
Compare
beliefer
reviewed
Jun 2, 2022
beliefer
reviewed
Jun 2, 2022
beliefer
reviewed
Jun 2, 2022
beliefer
reviewed
Jun 6, 2022
beliefer
reviewed
Jun 6, 2022
beliefer
reviewed
Jun 6, 2022
beliefer
reviewed
Jun 6, 2022
beliefer
left a comment
Contributor
There was a problem hiding this comment.
LGTM except one minor comment.
cc @cloud-fan @huaxingao
beliefer
approved these changes
Jun 6, 2022
cloud-fan
reviewed
Jun 9, 2022
cloud-fan
reviewed
Jun 9, 2022
cloud-fan
reviewed
Jun 22, 2022
beliefer
reviewed
Jun 22, 2022
cloud-fan
reviewed
Jun 22, 2022
beliefer
reviewed
Jun 22, 2022
beliefer
reviewed
Jun 22, 2022
beliefer
approved these changes
Jun 23, 2022
beliefer
left a comment
Contributor
There was a problem hiding this comment.
LGTM expect one comment.
beliefer
approved these changes
Jun 23, 2022
cloud-fan
reviewed
Jun 24, 2022
cloud-fan
reviewed
Jun 24, 2022
beliefer
reviewed
Jul 2, 2022
beliefer
left a comment
Contributor
There was a problem hiding this comment.
LGTM except one comment !
cloud-fan
reviewed
Jul 5, 2022
cloud-fan
reviewed
Jul 5, 2022
cloud-fan
reviewed
Jul 5, 2022
beliefer
reviewed
Jul 5, 2022
beliefer
reviewed
Jul 5, 2022
cloud-fan
reviewed
Jul 5, 2022
cloud-fan
approved these changes
Jul 5, 2022
Contributor
|
thanks, merging to master! |
Contributor
|
@cloud-fan @huaxingao Thank you for you review. |
Contributor
Author
|
@cloud-fan @beliefer @huaxingao Thank you for you review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, Spark have some datetime functions. Please refer
spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
Line 577 in 2f8613f
These functions show below:
DATE_ADD,DATEDIFF,TRUNC,EXTRACT,SECOND,MINUTE,HOUR,MONTH,QUARTER,YEAR,DAYOFWEEK,DAYOFMONTH,DAYOFYEARThe mainstream databases support these functions show below.
DateAddDateDiffDateTruncHourMinuteMonthQuarterSecondYearDayOfMonthDayOfWeekDayOfYearWEEK_OF_YEARYEAR_OF_WEEKDS V2 should supports push down these datetime functions.
Why are the changes needed?
DS V2 supports push down datetime functions.
Does this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
New tests.